Clean up imports and crate attributes#26
Clean up imports and crate attributes#26dtwood merged 1 commit intorust-embedded-community:masterfrom
Conversation
|
It appears that the rustfmt |
|
Thanks for the MR, all LGTM although it's a shame that we can't merge because of an unstable rustfmt feature. Looking through the diffs from the rustfmt check, I don't actually find the version without Two other things that I think should be possible if you want to add them:
|
The imports in most files appear to have been incompletely converted from edition 2015 to edition 2018, with duplicates and repeated prefixes. Additionally, some crate attributes were set separately when they could have been set jointly. This change cleans up imports and consolidates crate attributes. Some import sections have been annotated `#[rustfmt::skip]` and manually formatted for readability.
|
I have applied your recommendations, and am happy with the formatting I landed on. 😃 |
|
Thanks again for the MR, merged :-) |
2 participants
The imports in most files appear to have been incompletely converted from edition 2015 to edition 2018, with some duplicates and repeated prefixes. Additionally, some crate attributes were set separately when they could have been set jointly.
This change cleans up imports and consolidates crate attributes. Some import sections have been annotated
#[rustfmt::skip]and manually formatted for readability.